embed: return error when advertise-client-urls are with empty hosts #8786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Dec 21, 2017
embed/config.go
Outdated
| @@ -343,6 +343,7 @@ func (cfg *Config) Validate() error { | |||
| addrs[i] = cfg.ACUrls[i].String() | |||
| } | |||
| plog.Warningf("advertise-client-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) | |||
| return err | |||
There was a problem hiding this comment.
@harryge00 Can we remove the line 340 as well?
There was a problem hiding this comment.
Also make it as an error value
return fmt.Errorf("advertise-client-urls %q is deprecated (%v)", strings.Join(addrs, ","), err)It will be logged when etcd exits anyway
|
not sure how this solves the empty host issue. |
|
oh. ok. i see. we are returning the error from checkhost now. |
xiang90
reviewed
Dec 23, 2017
embed/config.go
Outdated
| @@ -343,6 +343,7 @@ func (cfg *Config) Validate() error { | |||
| addrs[i] = cfg.ACUrls[i].String() | |||
| } | |||
| plog.Warningf("advertise-client-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) | |||
There was a problem hiding this comment.
remove the warning? or change it to errorf?
|
@harryge00 can you help to resolve the comments? so that we can get this patch merged in? |
harryge00
force-pushed
the
check-empty-hostname
branch
from
4a8def7
to
fab17fc
Compare
harryge00
commented
Jan 25, 2018
embed/config.go
Outdated
| addrs := make([]string, len(cfg.APUrls)) | ||
| for i := range cfg.APUrls { | ||
| addrs[i] = cfg.APUrls[i].String() | ||
| } | ||
| plog.Warningf("advertise-peer-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) | ||
| return fmt.Errorf("advertise-peer-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) |
There was a problem hiding this comment.
Now only --initial-advertise-peer-urls available ?
|
Have you tried this branch with |
gyuho
reviewed
Jan 25, 2018
embed/config.go
Outdated
| addrs := make([]string, len(cfg.APUrls)) | ||
| for i := range cfg.APUrls { | ||
| addrs[i] = cfg.APUrls[i].String() | ||
| } | ||
| plog.Warningf("advertise-peer-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) | ||
| return fmt.Errorf("advertise-peer-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) |
There was a problem hiding this comment.
return fmt.Errorf(`--initial-advertise-peer-urls %q must be "host:port" (%v)`, strings.Join(addrs, ","), err)
gyuho
reviewed
Jan 25, 2018
embed/config.go
Outdated
| addrs := make([]string, len(cfg.ACUrls)) | ||
| for i := range cfg.ACUrls { | ||
| addrs[i] = cfg.ACUrls[i].String() | ||
| } | ||
| plog.Warningf("advertise-client-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) | ||
| return fmt.Errorf("advertise-client-urls %q is deprecated (%v)", strings.Join(addrs, ","), err) |
There was a problem hiding this comment.
return fmt.Errorf(`--advertise-client-urls %q must be "host:port" (%v)`, strings.Join(addrs, ","), err)
…eer-urls are with empty hosts
harryge00
force-pushed
the
check-empty-hostname
branch
from
fab17fc
to
6912a8e
Compare
Yes @gyuho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #8379
Not sure if this is what wanted. 😅