Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add client support for discovery-srv-name #10250

Merged
merged 3 commits into from
Nov 9, 2018

Conversation

hexfusion
Copy link
Contributor

Fixes #10238

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #10250 into master will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10250      +/-   ##
==========================================
+ Coverage   71.75%   71.81%   +0.05%     
==========================================
  Files         390      390              
  Lines       36351    36369      +18     
==========================================
+ Hits        26083    26117      +34     
+ Misses       8464     8443      -21     
- Partials     1804     1809       +5
Impacted Files Coverage Δ
client/discover.go 0% <0%> (ø) ⬆️
etcdctl/ctlv3/ctl.go 100% <100%> (ø) ⬆️
pkg/srv/srv.go 80.88% <100%> (+1.85%) ⬆️
etcdmain/grpc_proxy.go 64.58% <100%> (+0.14%) ⬆️
etcdmain/gateway.go 33.87% <50%> (+1.08%) ⬆️
etcdmain/util.go 5.17% <50%> (ø) ⬆️
etcdctl/ctlv3/command/global.go 59% <66.66%> (+0.21%) ⬆️
etcdctl/ctlv2/command/util.go 45.5% <87.5%> (+0.93%) ⬆️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
pkg/transport/listener.go 58.67% <0%> (-4.09%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83304cf...e0f7807. Read the comment docs.

@gyuho
Copy link
Contributor

gyuho commented Nov 9, 2018

@hexfusion Can we add tests? Runbook should be good enough (e.g. https://github.com/etcd-io/etcd/tree/master/tests/docker-dns-srv).

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Contributor Author

@gyuho I added tests for docker-dns-srv-test-certs-run, let me know if this is what you were thinking, thanks.

@gyuho
Copy link
Contributor

gyuho commented Nov 9, 2018

@hexfusion Also changelogs? Then should be good to merge. Thanks!

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Contributor Author

@gyuho changelog updated.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@hexfusion hexfusion merged commit 9454c4c into etcd-io:master Nov 9, 2018
@hexfusion hexfusion deleted the fx_discovery-srv-name branch November 9, 2018 21:31
@hexfusion
Copy link
Contributor Author

/cc @mrrandrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants