-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add client support for discovery-srv-name #10250
Conversation
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
0902c78
to
fa35126
Compare
Codecov Report
@@ Coverage Diff @@
## master #10250 +/- ##
==========================================
+ Coverage 71.75% 71.81% +0.05%
==========================================
Files 390 390
Lines 36351 36369 +18
==========================================
+ Hits 26083 26117 +34
+ Misses 8464 8443 -21
- Partials 1804 1809 +5
Continue to review full report at Codecov.
|
@hexfusion Can we add tests? Runbook should be good enough (e.g. https://github.com/etcd-io/etcd/tree/master/tests/docker-dns-srv). |
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@gyuho I added tests for docker-dns-srv-test-certs-run, let me know if this is what you were thinking, thanks. |
@hexfusion Also changelogs? Then should be good to merge. Thanks! |
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@gyuho changelog updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
/cc @mrrandrade |
Fixes #10238