raft: ensure leader is in ProgressStateReplicate #10279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10279 +/- ##
==========================================
- Coverage 71.72% 71.72% -0.01%
==========================================
Files 391 391
Lines 36375 36376 +1
==========================================
Hits 26090 26090
+ Misses 8474 8473 -1
- Partials 1811 1813 +2
Continue to review full report at Codecov.
|
bdarnell
approved these changes
Nov 20, 2018
|
Hi @tbg can we fix this CI failure please https://travis-ci.com/etcd-io/etcd/jobs/159792633 |
siddontang
reviewed
Nov 20, 2018
siddontang
reviewed
Nov 20, 2018
|
lgtm. |
tbg
changed the title
tbg
force-pushed
the
leader-progress-replicate
branch
from
e33820b
to
e41c1b7
Compare
The leader perpetually kept itself in ProgressStateProbe even though of course it has perfect knowledge of its log. This wasn't usually an issue because it also doesn't care about its own Progress, but it's better to keep this data correctly maintained, especially since this is part of raft.Status and thus becomes visible to applications using the Raft library. (Concretely, in CockroachDB we use the Progress to inform log truncations).
tbg
force-pushed
the
leader-progress-replicate
branch
from
e41c1b7
to
5c209d6
Compare
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Apr 6, 2022
Addresses a long-standing TODO. We picked up etcd-io/etcd#10279 a while ago.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Apr 7, 2022
79522: kv: remove raft leader progress override in newTruncateDecision r=nvanbenschoten a=nvanbenschoten Addresses a long-standing TODO. We picked up etcd-io/etcd#10279 a while ago. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leader perpetually kept itself in ProgressStateProbe even though of
course it has perfect knowledge of its log. This wasn't usually an issue
because it also doesn't care about its own Progress, but it's better to
keep this data correctly maintained, especially since this is part of
raft.Status and thus becomes visible to applications using the Raft
library.
(Concretely, in CockroachDB we use the Progress to inform log
truncations).