Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
discoveryserver: implement a minimal discovery API on top of v3 APIs #10627
To make the etcd discovery service maintainable by the CNCF (coreos/discovery.etcd.io#63) we should make it easy to run on the v3 API and storage.
This discoveryserver package implements enough of the v2 API alongside the existing discovery.etcd.io API. I have tested it just now with the
This PR is operating under a deadline. One of the AWS nodes that is running discovery.etcd.io is scheduled for deletion on April 16th. So, ideally I can get a Kubernetes cluster up, an etcd Operator backed etcd cluster, and this code all running by end of week.
referenced this pull request
Apr 11, 2019
This was referenced
Apr 11, 2019
Thanks! Are the tests just always failing now? I feel the test failures are all unrelated.…
On Sun, Apr 14, 2019 at 3:59 PM Xiang Li ***@***.***> wrote: @philips <https://github.com/philips> I skimmed this PR. Overall, looks reasonable good, just a few nits. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10627 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACDCKXuBQpT3iqVMtUfMdrzuKiwObBFks5vg7LigaJpZM4cojOd> .
@@ Coverage Diff @@ ## master #10627 +/- ## ========================================== + Coverage 71.51% 71.94% +0.42% ========================================== Files 394 406 +12 Lines 36658 36988 +330 ========================================== + Hits 26217 26610 +393 + Misses 8595 8479 -116 - Partials 1846 1899 +53