clientv3/concurrency: Added Mutex.TryLock() #11104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimalk78
force-pushed
the
clientv3-fixes
branch
from
cbe41aa
to
d054d5a
Compare
xiang90
reviewed
Sep 6, 2019
xiang90
reviewed
Sep 6, 2019
xiang90
reviewed
Sep 6, 2019
|
lgtm in general. defer to @gyuho |
gyuho
reviewed
Sep 6, 2019
TryLock locks the mutex if not already locked by another session. If lock is held by another session, return immediately after attempting necessary cleanup Added integration test Fixes etcd-io#10493
vimalk78
force-pushed
the
clientv3-fixes
branch
from
d054d5a
to
04ddfa8
Compare
|
lgtm |
|
@gyuho you can get this merged if you are ok with it. |
vimalk78
added a commit
to vimalk78/etcd
that referenced
this pull request
Sep 12, 2019
Added etcd-io#11104 to CHANGELOG for 3.5
sgotti
added a commit
to sgotti/agola
that referenced
this pull request
Nov 12, 2019
etcd PR 11104 (etcd-io/etcd#11104) implemented mutex TryLock. Since it's only available in etcd master just copy relevant code and add a TODO to remove it when updating the etcd client to a version implementing TryLock. Use TryLock everywhere where it'll be useful.
sgotti
added a commit
to sgotti/agola
that referenced
this pull request
Nov 12, 2019
etcd PR 11104 (etcd-io/etcd#11104) implemented mutex TryLock. Since it's only available in etcd master just copy relevant code and add a TODO to remove it when updating the etcd client to a version implementing TryLock. Use TryLock everywhere where it'll be useful.
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
etcd PR 11104 (etcd-io/etcd#11104) implemented mutex TryLock. Since it's only available in etcd master just copy relevant code and add a TODO to remove it when updating the etcd client to a version implementing TryLock. Use TryLock everywhere where it'll be useful.
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
etcd PR 11104 (etcd-io/etcd#11104) implemented mutex TryLock. Since it's only available in etcd master just copy relevant code and add a TODO to remove it when updating the etcd client to a version implementing TryLock. Use TryLock everywhere where it'll be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryLock locks the mutex if not already locked by another session.
If lock is held by another session, return immediately after attempting necessary cleanup
Fixes #10493
Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.