Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdctl: support progress notify option #11462

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Dec 17, 2019

Add --progress-notify to etcdctl watch command. Example output:

$ etcdctl watch foo --progress-notify
progress notify: 1272
progress notify: 1789
progress notify: 2001
progress notify: 2001
...

Add support for progress notify option to etcdctl watch command.
@codecov-io
Copy link

Codecov Report

Merging #11462 into master will decrease coverage by 0.26%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11462      +/-   ##
==========================================
- Coverage   64.21%   63.95%   -0.27%     
==========================================
  Files         403      403              
  Lines       38079    38082       +3     
==========================================
- Hits        24453    24354      -99     
- Misses      11993    12096     +103     
+ Partials     1633     1632       -1
Impacted Files Coverage Δ
etcdctl/ctlv3/command/watch_command.go 44.08% <33.33%> (-0.18%) ⬇️
pkg/transport/timeout_conn.go 60% <0%> (-20%) ⬇️
auth/jwt.go 58.09% <0%> (-10.48%) ⬇️
auth/store.go 45.66% <0%> (-7.79%) ⬇️
pkg/netutil/netutil.go 63.11% <0%> (-7.38%) ⬇️
clientv3/leasing/util.go 91.66% <0%> (-6.67%) ⬇️
clientv3/concurrency/mutex.go 62.16% <0%> (-5.41%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0%> (-4.77%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
proxy/grpcproxy/watch.go 89.94% <0%> (-2.96%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5770a6d...c0de070. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jingyih LGTM Also, couple of observations - requires changelog updates, and wondering if we should support this in 3.3 as well.

@xiang90
Copy link
Contributor

xiang90 commented Jan 1, 2020

lgtm. can you add change log?

@jingyih
Copy link
Contributor Author

jingyih commented Jan 14, 2020

wondering if we should support this in 3.3 as well.

I think generally we do not want to backport a new flag.

@jingyih
Copy link
Contributor Author

jingyih commented Jan 14, 2020

CHANGELOG updated in the same PR. PTAL.

@spzala
Copy link
Member

spzala commented Jan 14, 2020

wondering if we should support this in 3.3 as well.

I think generally we do not want to backport a new flag.

OK, that's fair. Thanks @jingyih LGTM.

@spzala
Copy link
Member

spzala commented Jan 14, 2020

Merging as @xiang90 also had lgtm earlier :)

@spzala spzala merged commit 908f45e into etcd-io:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants