-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdctl: support progress notify option #11462
etcdctl: support progress notify option #11462
Conversation
Add support for progress notify option to etcdctl watch command.
Codecov Report
@@ Coverage Diff @@
## master #11462 +/- ##
==========================================
- Coverage 64.21% 63.95% -0.27%
==========================================
Files 403 403
Lines 38079 38082 +3
==========================================
- Hits 24453 24354 -99
- Misses 11993 12096 +103
+ Partials 1633 1632 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jingyih LGTM Also, couple of observations - requires changelog updates, and wondering if we should support this in 3.3 as well.
lgtm. can you add change log? |
I think generally we do not want to backport a new flag. |
CHANGELOG updated in the same PR. PTAL. |
OK, that's fair. Thanks @jingyih LGTM. |
Merging as @xiang90 also had lgtm earlier :) |
Add
--progress-notify
toetcdctl watch
command. Example output: