proxy: remove capnslog #11614
Merged
proxy: remove capnslog #11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11614 +/- ##
==========================================
- Coverage 66.56% 66.22% -0.34%
==========================================
Files 403 403
Lines 36630 36661 +31
==========================================
- Hits 24381 24277 -104
- Misses 10768 10894 +126
- Partials 1481 1490 +9
Continue to review full report at Codecov.
|
spzala
reviewed
Feb 12, 2020
proxy/httpproxy/reverse.go
Outdated
| @@ -75,10 +75,14 @@ func (p *reverseProxy) ServeHTTP(rw http.ResponseWriter, clientreq *http.Request | |||
| proxybody, err = ioutil.ReadAll(clientreq.Body) | |||
| if err != nil { | |||
| msg := fmt.Sprintf("failed to read request body: %v", err) | |||
| plog.Println(msg) | |||
| p.lg.Info(msg, zap.Error(err)) | |||
There was a problem hiding this comment.
@jingyih thanks, lgtm except one comment here that, the msg already has err so we shouldn't repeat it, and just use p.lg.Info(msg) or remove err from the msg? Thanks!
jingyih
force-pushed
the
remove_capnslog_in_proxy
branch
from
3d8c801
to
81f00b0
Compare
gyuho
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency of
capnsloginproxypackage.Related: #11426