Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdctl: support query count only of specified prefix #11743

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

mlmhl
Copy link
Contributor

@mlmhl mlmhl commented Apr 2, 2020

Sometimes we only want to know how many objects under a specified prefix, instead of extracting the whole keys or values.

@codecov-io
Copy link

Codecov Report

Merging #11743 into master will decrease coverage by 0.05%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11743      +/-   ##
==========================================
- Coverage   66.12%   66.06%   -0.06%     
==========================================
  Files         403      403              
  Lines       36792    36800       +8     
==========================================
- Hits        24327    24313      -14     
- Misses      10967    10973       +6     
- Partials     1498     1514      +16     
Impacted Files Coverage Δ
etcdctl/ctlv3/command/get_command.go 16.66% <12.50%> (-0.38%) ⬇️
client/client.go 44.11% <0.00%> (-22.55%) ⬇️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
client/keys.go 76.88% <0.00%> (-14.58%) ⬇️
proxy/grpcproxy/register.go 72.50% <0.00%> (-10.00%) ⬇️
pkg/netutil/netutil.go 61.47% <0.00%> (-7.38%) ⬇️
pkg/tlsutil/tlsutil.go 86.20% <0.00%> (-6.90%) ⬇️
clientv3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
clientv3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
etcdserver/api/v3rpc/lease.go 77.21% <0.00%> (-5.07%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0941cfc...aa7b056. Read the comment docs.

@mlmhl
Copy link
Contributor Author

mlmhl commented Apr 2, 2020

@gyuho @mitake PTAL :)

@xiang90
Copy link
Contributor

xiang90 commented Apr 4, 2020

The change LGTM.

@mlmhl Can you add this new feature to the changelog? Thanks

mlmhl added a commit to mlmhl/etcd that referenced this pull request Apr 6, 2020
@mlmhl
Copy link
Contributor Author

mlmhl commented Apr 6, 2020

@xiang90 Of cause, I submitted a PR to update the CHANGELOG, PTAL :).

Copy link
Contributor

@mitake mitake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mitake mitake merged commit 5eacb4b into etcd-io:master Apr 6, 2020
mitake added a commit that referenced this pull request Apr 6, 2020
tangcong pushed a commit to tangcong/etcd that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants