Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ETCD_UNSUPPORTED_ARCH to ARM64 #12557

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Dec 15, 2020

Resolves #12543 ,

Set the ETCD_UNSUPPORTED_ARCH environment variable to ARM64 in Docker-release.arm64.

Signed-off-by: odidev odidev@puresoftware.com

Signed-off-by: odidev <odidev@puresoftware.com>
@ptabor
Copy link
Contributor

ptabor commented Jan 15, 2021

@glevand, could you please take a look at this change ?

@stale
Copy link

stale bot commented Apr 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2021
@odidev
Copy link
Contributor Author

odidev commented Apr 16, 2021

@glevand,

can u please provide me your suggestion on this PR

@stale stale bot removed the stale label Apr 16, 2021
@glevand
Copy link
Contributor

glevand commented Apr 16, 2021

LGTM.
For ARM64, the scripts build-docker, test.sh, and build-release.sh all use Dockerfile-release.arm64 to build Docker container images.
We need ETCD_UNSUPPORTED_ARCH set when running etcd on ARM64 otherwise running the container ends in failure.

@xiang90
Copy link
Contributor

xiang90 commented May 4, 2021

LGTM. The CI failure is unrelated.

@xiang90 xiang90 merged commit 7296a07 into etcd-io:master May 4, 2021
tangcong pushed a commit to tangcong/etcd that referenced this pull request May 15, 2021
Signed-off-by: odidev <odidev@puresoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Facing “ENV ETCD_UNSUPPORTED_ARCH=arm64” issue using arm64 docker image
4 participants