client: Bring back ETCD_CLIENT_DEBUG variable interpretation. #12786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20210318-debug-env
branch
4 times, most recently
from
6bd9653
to
e7946e5
Compare
env ETCD_CLIENT_DEBUG supports log levels (debug, info, warn, error, dpanic, panic, fatal). Only when set, overrides application-wide grpc logging settings.
ptabor
force-pushed
the
20210318-debug-env
branch
from
e7946e5
to
9312d1b
Compare
gyuho
reviewed
Mar 18, 2021
| default: | ||
| panic(fmt.Sprintf("unknown level %q", lvl)) | ||
| var level zapcore.Level | ||
| if err := level.Set(lvl); err != nil { |
``` gofmt' started at Thu Mar 18 18:06:00 UTC 2021 transport/sockopt_unix.go diff -u transport/sockopt_unix.go.orig transport/sockopt_unix.go --- transport/sockopt_unix.go.orig 2021-03-18 18:06:01.667483834 +0000 +++ transport/sockopt_unix.go 2021-03-18 18:06:01.667483834 +0000 @@ -1,3 +1,4 @@ +//go:build !windows // +build !windows package transport transport/sockopt_windows.go diff -u transport/sockopt_windows.go.orig transport/sockopt_windows.go --- transport/sockopt_windows.go.orig 2021-03-18 18:06:01.667483834 +0000 +++ transport/sockopt_windows.go 2021-03-18 18:06:01.667483834 +0000 @@ -1,3 +1,4 @@ +//go:build windows // +build windows ```
|
This is affected by flake: TestBalancerUnderNetworkPartitionWatchLeader that gets fixed in: #12782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env ETCD_CLIENT_DEBUG supports log levels (debug, info, warn, error, dpanic, panic, fatal).
Only when set, overrides application-wide grpc logging settings.