etcdserver: resend ReadIndex request on empty apply request #12795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpedrak
force-pushed
the
resend-read-index-on-first-commit-in-term
branch
from
c168f5c
to
06a627a
Compare
ptabor
suggested changes
Mar 24, 2021
wpedrak
force-pushed
the
resend-read-index-on-first-commit-in-term
branch
from
06a627a
to
1d96146
Compare
ptabor
reviewed
Mar 28, 2021
server/etcdserver/server.go
Outdated
| @@ -2067,6 +2081,8 @@ func (s *EtcdServer) applyEntryNormal(e *raftpb.Entry) { | |||
| // raft state machine may generate noop entry when leader confirmation. | |||
| // skip it in advance to avoid some potential bug in the future | |||
| if len(e.Data) == 0 { | |||
| s.notifyAboutFirstCommitInTerm() | |||
|
|
|||
| select { | |||
| case s.forceVersionC <- struct{}{}: | |||
There was a problem hiding this comment.
Please add at least a TODO to replace forceVersionC with FirstCommitInTermNotify as they do exactly the same thing.
ptabor
reviewed
Mar 28, 2021
wpedrak
force-pushed
the
resend-read-index-on-first-commit-in-term
branch
from
1d96146
to
58ceed4
Compare
|
Test I've added was flaky once I've set cluster size to 21. It was failing with |
ptabor
reviewed
Apr 8, 2021
ptabor
suggested changes
Apr 8, 2021
Empty apply indicates first commit in current term. It is first time when follower is sure, that it's ReadIndex request can be processed.
wpedrak
force-pushed
the
resend-read-index-on-first-commit-in-term
branch
from
58ceed4
to
943bcc3
Compare
ptabor
reviewed
Apr 9, 2021
|
|
||
| err = group.Wait() | ||
| if err != nil { | ||
| t.Errorf("korona %v", err) |
ptabor
approved these changes
Apr 9, 2021
wpedrak
force-pushed
the
resend-read-index-on-first-commit-in-term
branch
from
943bcc3
to
08ea9cb
Compare
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Jul 25, 2022
Backport etcd-io#12795 to 3.4 Signed-off-by: Benjamin Wang <wachao@vmware.com>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 8, 2022
Backport etcd-io#12795 to 3.4 Signed-off-by: Benjamin Wang <wachao@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty apply indicates first commit in current term. It is first time when follower is sure, that its ReadIndex request can be processed.
Idea for this PR was born in discussion under #12762 (comment).