Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Use gcloud auth configure-docker instead of gcloud docker ... for test-images #12873

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Apr 17, 2021

Makefile: Use gcloud auth configure-docker instead of gcloud docker ...

Needed for: #12732

@codecov-commenter
Copy link

Codecov Report

Merging #12873 (5ad8880) into master (f3c5180) will decrease coverage by 26.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12873       +/-   ##
===========================================
- Coverage   71.86%   45.30%   -26.57%     
===========================================
  Files         427      348       -79     
  Lines       33805    29128     -4677     
===========================================
- Hits        24294    13196    -11098     
- Misses       7559    14280     +6721     
+ Partials     1952     1652      -300     
Flag Coverage Δ
all 45.30% <ø> (-26.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/v3/txn.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/types/id.go 0.00% <0.00%> (-100.00%) ⬇️
client/v3/ordering/util.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/logutil/zap.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/types/slice.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/fileutil/dir_unix.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/fileutil/read_dir.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/fileutil/sync_linux.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/tlsutil/cipher_suites.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/sockopt_unix.go 0.00% <0.00%> (-100.00%) ⬇️
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c5180...5ad8880. Read the comment docs.

@ptabor ptabor merged commit ce3dae6 into etcd-io:master Apr 21, 2021
@ptabor ptabor deleted the 20210417-test-docker-gcloud branch April 21, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants