Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Add verification of whether lock was called within out outside of apply #13885

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

serathius
Copy link
Member

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #13885 (34c0a55) into main (6c974a3) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 34c0a55 differs from pull request most recent head 1d35170. Consider uploading reports for the commit 1d35170 to get more accurate results

@@            Coverage Diff             @@
##             main   #13885      +/-   ##
==========================================
- Coverage   72.51%   72.37%   -0.14%     
==========================================
  Files         468      469       +1     
  Lines       38255    38276      +21     
==========================================
- Hits        27739    27704      -35     
- Misses       8734     8785      +51     
- Partials     1782     1787       +5     
Flag Coverage Δ
all 72.37% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/backend/batch_tx.go 60.79% <0.00%> (-2.15%) ⬇️
server/storage/backend/verify.go 0.00% <0.00%> (ø)
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-9.31%) ⬇️
client/pkg/v3/fileutil/lock_linux.go 72.22% <0.00%> (-8.34%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 75.52% <0.00%> (-7.30%) ⬇️
server/storage/wal/file_pipeline.go 90.69% <0.00%> (-4.66%) ⬇️
server/storage/mvcc/watchable_store.go 85.86% <0.00%> (-3.27%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
client/v3/experimental/recipes/key.go 75.34% <0.00%> (-2.74%) ⬇️
client/pkg/v3/testutil/leak.go 60.17% <0.00%> (-2.66%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c974a3...1d35170. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants