Change default sampling rate from 100% to 0% #14318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default parent-based trace sampling rate from 100% to 0%. Due to the high QPS etcd can handle, having 100% trace sampling leads to very high resource usage. Defaulting to 0% means that only already-sampled traces will be sampled in etcd. Fixes etcd-io#14310 Signed-off-by: Mike Dame <mikedame@google.com>
damemi
force-pushed
the
3.5-tracing-sample
branch
from
1eac202
to
4c013c9
Compare
|
cc @dashpole |
dashpole
approved these changes
Aug 5, 2022
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Aug 6, 2022
Refer to etcd-io#14318 Signed-off-by: Benjamin Wang <wachao@vmware.com>
|
Also thanks @dashpole for the review. |
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Aug 6, 2022
Refer to etcd-io#14318 Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Aug 6, 2022
Refer to etcd-io#14318 Signed-off-by: Benjamin Wang <wachao@vmware.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/etcd
that referenced
this pull request
Oct 7, 2022
Refer to etcd-io#14318 Signed-off-by: Benjamin Wang <wachao@vmware.com>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Jul 26, 2023
Refer to etcd-io#14318 Signed-off-by: Benjamin Wang <wachao@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default parent-based trace sampling rate from
100% to 0%. Due to the high QPS etcd can handle, having 100% trace
sampling leads to very high resource usage. Defaulting to 0% means
that only already-sampled traces will be sampled in etcd.
Fixes #14310