Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix client fileutil log, backport to v3.5 #14740

Closed

Conversation

halegreen
Copy link
Contributor

@halegreen halegreen commented Nov 12, 2022

backport #13401 to v3.5: client/pkg/fileutil: add missing logger to {Create,Touch}DirAll

Also populate it to every invocation.

fix #14736
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

…Touch}DirAll

Also populate it to every invocation.

Signed-off-by: WangXiaoxiao <1141195807@qq.com>
@halegreen halegreen changed the title client:fix client fileutil log client: fix client fileutil log, backport to v3.5 Nov 12, 2022
@serathius
Copy link
Member

serathius commented Nov 13, 2022

Please fix remaining calls for the tests to pass

@ahrtr
Copy link
Member

ahrtr commented Nov 15, 2022

@halegreen any update on this? Please fix the pipeline failures.

@serathius
Copy link
Member

With no answer from @halegreen I will be taking over the work needed to backport this.

@serathius
Copy link
Member

PTAL #14799

@serathius serathius closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants