Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency: bump google.golang.org/grpc from 1.51.0 to 1.52.0 #15131

Closed
wants to merge 1 commit into from
Closed

dependency: bump google.golang.org/grpc from 1.51.0 to 1.52.0 #15131

wants to merge 1 commit into from

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 17, 2023

dependabot automaticaly bumped gRPC, but unfortunately it doesn't execute "./scripts/fix.sh", and it also created a PR for each module.

@ahrtr ahrtr marked this pull request as draft January 17, 2023 05:32
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #15131 (ca7d210) into main (a3925d1) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #15131      +/-   ##
==========================================
- Coverage   74.90%   74.57%   -0.34%     
==========================================
  Files         415      415              
  Lines       34343    34343              
==========================================
- Hits        25726    25610     -116     
- Misses       7003     7094      +91     
- Partials     1614     1639      +25
Flag Coverage Δ
all 74.57% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-11.63%) ⬇️
client/pkg/v3/testutil/leak.go 62.83% <0.00%> (-7.08%) ⬇️
client/pkg/v3/fileutil/purge.go 68.85% <0.00%> (-6.56%) ⬇️
server/etcdserver/api/v3rpc/watch.go 83.49% <0.00%> (-5.08%) ⬇️
client/v3/leasing/cache.go 87.22% <0.00%> (-4.45%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 73.43% <0.00%> (-4.17%) ⬇️
server/storage/mvcc/watchable_store.go 85.14% <0.00%> (-3.99%) ⬇️
server/etcdserver/txn/util.go 96.42% <0.00%> (-3.58%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 71.30% <0.00%> (-3.48%) ⬇️
client/pkg/v3/testutil/recorder.go 76.27% <0.00%> (-3.39%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahrtr
dependency: bump google.golang.org/grpc from 1.51.0 to 1.52.0
ca7d210 
ServerName field of the resolver returned address takes precedence
over Host field of CallHdr to determine the :authority header.
Refer to grpc/grpc-go#5748

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr ahrtr marked this pull request as ready for review January 17, 2023 06:16
serathius
serathius reviewed Jan 17, 2023
View reviewed changes
tests/e2e/ctl_v3_grpc_test.go
@@ -41,38 +41,38 @@ func TestAuthority(t *testing.T) {
{
name: "http://domain[:port]",
clientURLPattern: "http://localhost:${MEMBER_PORT}",
expectAuthorityPattern: "localhost:${MEMBER_PORT}",
expectAuthorityPattern: "localhost",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious and possibly a breaking change. Please check #13192. Having just host is a correct authority format (as port is optional), however I think it can break some setups that depend on that.
Before merging we should understand the grpc change that lead to that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change grpc/grpc-go#5748

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the commit message (Pasted below in case anyone miss it) and grpc/grpc-go#5748 (comment)

ServerName field of the resolver returned address takes precedence
over Host field of CallHdr to determine the :authority header.
Refer to https://github.com/grpc/grpc-go/pull/5748

@serathius
Copy link
Member

cc @ptabor

@ahrtr ahrtr mentioned this pull request Jan 18, 2023
Merged
@ahrtr ahrtr marked this pull request as draft February 1, 2023 02:20
@ahrtr ahrtr mentioned this pull request Feb 12, 2023
Closed
@ahrtr ahrtr mentioned this pull request Mar 22, 2023
Closed
@ahrtr
Copy link
Member Author

ahrtr commented Apr 13, 2023

linked to #15145

This was referenced May 1, 2023
Closed
Closed
@ahrtr ahrtr mentioned this pull request Jul 20, 2023
Closed
4 tasks
@chaochn47
Copy link
Member

chaochn47 commented Jul 22, 2023 •
edited
Loading

Umm, why not set the ServerName to Host:port in the first place in #12671?

etcd/client/v3/internal/resolver/resolver.go

Lines 66 to 67 in 9e1abba

addr, serverName := endpoint.Interpret(ep)
addresses[i] = resolver.Address{Addr: addr, ServerName: serverName}

cc @ptabor could you please shed some lights on this in case I missed something?

The port will be stripped away regardless when doing TLS client handshake thanks to grpc/grpc-go#3082.

@ahrtr ahrtr mentioned this pull request Jul 24, 2023
Closed
@chaochn47 chaochn47 mentioned this pull request Jul 28, 2023
Merged
@ahrtr
Copy link
Member Author

ahrtr commented Jul 31, 2023

superseded by #16324

@ahrtr ahrtr closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahrtr @codecov-commenter @serathius @chaochn47