[3.4] Return to default write scheduler since golang.org/x/net@v0.11.0 started using round robin #16782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
approved these changes
Oct 17, 2023
serathius
force-pushed
the
roundrobin-3.4
branch
from
d3b600f
to
21ab91b
Compare
|
Added backport of #15636 to reduce flakiness. |
…ted using round robin Introduction of round robin golang/net@120fc90 Added in v0.10.0 golang/net@v0.10.0...v0.11.0 Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
value is selected empirically after spot checking some logs of flaky workflows fixes: etcd-io#15634 Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
serathius
force-pushed
the
roundrobin-3.4
branch
from
771f3fd
to
2c527b2
Compare
|
Could you also add a changelog item for 3.4? |
nvm, let me take care of all the remaining changelog items for 3.4.28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of round robin golang/net@120fc90 Added in v0.10.0 golang/net@v0.10.0...v0.11.0
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Closes #15402