github workflow: enable workflow approval #16965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to run GitHub workflows for Pull Requests that have the ok-to-test label. Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
force-pushed
the
enable-github-workflow-approval-via-ok-to-test-label
branch
from
dae2673
to
2a463b5
Compare
ivanvc
changed the title
serathius
approved these changes
Nov 18, 2023
|
close/reopen to re-trigger all arm64 workflows |
jmhbnz
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
LGTM - Thanks @ivanvc 🙏🏻
Note: The robustness test is stuck right now until we re-enable large runners after the etcd org was moved from CNCF to Kubernetes GitHub enterprise account, we have an open issue under kubernetes/org to get this done.
ivanvc
deleted the
enable-github-workflow-approval-via-ok-to-test-label
branch
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to run GitHub workflows for Pull Requests that have the ok-to-test label.
Fixes #16956
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.