Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 16822 changes and dependencies #17240

Closed
wants to merge 1 commit into from
Closed

Backport 16822 changes and dependencies #17240

wants to merge 1 commit into from

Conversation

amit-rastogi
Copy link

This PR contains changes for backporting #16822 dependencies only.
Please refer to PR #17196 for backporting changes related to #16822.

With these changes "make test-unit" gives the following errors which would need additional changes-

stderr: # go.etcd.io/etcd/tests/v3/framework/e2e
stderr: framework/e2e/etcdctl.go:34:22: undefined: clientv3.AuthConfig
stderr: framework/e2e/etcdctl.go:124:16: cmd.ExpectWithContext undefined (type *expect.ExpectProcess has no field or method ExpectWithContext)
stderr: framework/e2e/etcdctl.go:124:46: undefined: expect.ExpectedResponse
stderr: framework/e2e/etcdctl.go:148:30: BinPath.Etcdctl undefined (type string has no field or method Etcdctl)
stderr: framework/e2e/etcdctl.go:185:19: cmd.ExpectWithContext undefined (type *expect.ExpectProcess has no field or method ExpectWithContext)
stderr: framework/e2e/etcdctl.go:185:49: undefined: expect.ExpectedResponse 

All backporting changes in this PR have been confined to the tests/framework however, the below error related to clientv3.AuthConfig and cmd.ExpectWithContext would require changes outside the test framework like-
client/v3/config.go
pkg/expect/expect.go

This PR is to get feedback if making changes outside the test\framework for backporting should be feasible or alternatively, re-write\modify tests/e2e/v3_lease_no_proxy_test.go in v3.5 to use available v3.5 interface wherever feasible specially related to EtcdctlV3 and NewEtcdctl.

Signed-off-by: Amit Rastogi <amitrastogi2206@gmail.com>
@k8s-ci-robot
Copy link

Hi @amit-rastogi. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahrtr
Copy link
Member

ahrtr commented Jan 13, 2024

We don't have to necessarily backport everything. I suggest to just try to implement WaitLeader in 3.5 and 3.4.

@ahrtr ahrtr mentioned this pull request Jan 26, 2024
@ahrtr
Copy link
Member

ahrtr commented Feb 1, 2024

Talked with the the amit-rastogi, he will not continue to work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants