Backport 16822 changes and dependencies #17240
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes for backporting #16822 dependencies only.
Please refer to PR #17196 for backporting changes related to #16822.
With these changes "make test-unit" gives the following errors which would need additional changes-
All backporting changes in this PR have been confined to the tests/framework however, the below error related to clientv3.AuthConfig and cmd.ExpectWithContext would require changes outside the test framework like-
client/v3/config.go
pkg/expect/expect.go
This PR is to get feedback if making changes outside the test\framework for backporting should be feasible or alternatively, re-write\modify tests/e2e/v3_lease_no_proxy_test.go in v3.5 to use available v3.5 interface wherever feasible specially related to EtcdctlV3 and NewEtcdctl.