[3.4] tests/e2e: backport WaitLeader #17398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Etcdctl function to etcdProcess interface, and implement it in etcdServerProcess, which is used by WaitMembersForLeader. Define Etcdctl's Status function, that is used by WaitMembersForLeader too. Signed-off-by: Ivan Valdes <ivan@vald.es>
|
Hi @ivanvc. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
serathius
approved these changes
Feb 9, 2024
|
/ok-to-test |
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
Feb 20, 2024
Fixes the incorrect backport of WaitLeader, as spawnJsonCmd receives an expected output string as an argument, which wasn't provided in the first backport implementation. Original backport of commit 371179e from PR etcd-io#17398. Signed-off-by: Ivan Valdes <ivan@vald.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #17381, backports e2e
WaitLeaderinto 3.4.Relates to #16822, #15247
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.