Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]backport pkg/expect enhancements from main #18051

Open
wants to merge 3 commits into
base: release-3.5
Choose a base branch
from
Open

[WIP]backport pkg/expect enhancements from main #18051

wants to merge 3 commits into from

Conversation

ArkaSaha30
Copy link
Contributor

This PR will backport pkg/expect enhancements from main to LTS branch release-3.5 to keep the test framework consistent.

Issue: #17869

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30 ArkaSaha30 changed the title backport pkg/expect enhancements from main [WIP]backport pkg/expect enhancements from main May 22, 2024
@ArkaSaha30 ArkaSaha30 force-pushed the backport-pkg-expect-enhancements branch 3 times, most recently from 70726c4 to d9615e2 Compare May 23, 2024 12:12
@eval-exec @ArkaSaha30
[3.5]backport: pkg/expect: send SIGTERM to target expect process inst…
4f33d5b 
…ead of SIGKILL

Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@ArkaSaha30 ArkaSaha30 force-pushed the backport-pkg-expect-enhancements branch from d9615e2 to 4f33d5b Compare May 23, 2024 12:22
@tjungblu @ArkaSaha30
[3.5]backport: Reduce ExpectFunc polling interval.
ea94399 
Fixes issue 14275, flakes close to timeout like TestKVDelete.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
@tjungblu @ArkaSaha30
[3.5]backport: Add test name to e2e cluster members
a37b082 
This should aid in debugging test flakes, especially in tests where the process is restarted very often and thus changes its pid.
Now it's a lot easier to grep for different members, also when different tests fail at the same time.
The test TestDowngradeUpgradeClusterOf3 as mentioned in etcd-io#13167 is a good example for that.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@fuweid fuweid self-requested a review May 27, 2024 09:07
@k8s-ci-robot
Copy link

@ArkaSaha30: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-smoke-4-cpu-arm64 a37b082 link true /test pull-etcd-smoke-4-cpu-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid Awaiting requested review from fuweid

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress needs-ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArkaSaha30 @k8s-ci-robot @eval-exec @tjungblu