Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bugfix: register of walWriteSec #18174

Conversation

andyxning
Copy link
Contributor

Signed-off-by: Andy Xie <andy.xning@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from ivanvc June 14, 2024 01:38
@k8s-ci-robot
Copy link

Hi @andyxning. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jun 14, 2024

/ok-to-test

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Thank you.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @andyxning. Could you open a PR to update 3.5's CHANGELOG with this bug fix as pointed out by Benjamin? Thanks again.

@ahrtr ahrtr merged commit 5b25d6b into etcd-io:release-3.5 Jun 15, 2024
27 checks passed
@andyxning andyxning deleted the automated-cherry-pick-of-#18164-origin-release-3.5 branch June 17, 2024 01:51
@andyxning
Copy link
Contributor Author

@ivanvc This is a bugfix to adding support for walWriteSec and walWriteSec was added in v3.5. There is no need to update in the changelog, imho.

@ivanvc
Copy link
Member

ivanvc commented Jun 17, 2024

@ivanvc This is a bugfix to adding support for walWriteSec and walWriteSec was added in v3.5. There is no need to update in the changelog, imho.

Yes, but at least 3.5.14 was released with this bug. I think that's why we need the release note, and why Benjamin requested it.

@ivanvc
Copy link
Member

ivanvc commented Jun 28, 2024

/retitle [3.5] bugfix: register of walWriteSec

@k8s-ci-robot k8s-ci-robot changed the title bugfix: register of walWriteSec [3.5] bugfix: register of walWriteSec Jun 28, 2024
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
…-of-#18164-origin-release-3.5

bugfix: register of walWriteSec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants