-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] bugfix: register of walWriteSec #18174
[3.5] bugfix: register of walWriteSec #18174
Conversation
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Hi @andyxning. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @andyxning. Could you open a PR to update 3.5's CHANGELOG with this bug fix as pointed out by Benjamin? Thanks again.
@ivanvc This is a bugfix to adding support for |
Yes, but at least 3.5.14 was released with this bug. I think that's why we need the release note, and why Benjamin requested it. |
/retitle [3.5] bugfix: register of walWriteSec |
…-of-#18164-origin-release-3.5 bugfix: register of walWriteSec
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cherry-pick #18164 to release-3.5
/cc @ivanvc