robustness: Separate compaction and LazyFS test scenario for cluster size 1 #18179
Conversation
…size 1. Signed-off-by: Siyuan Zhang <sizhang@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #18179 +/- ##
==========================================
- Coverage 68.82% 68.81% -0.01%
==========================================
Files 416 416
Lines 35128 35128
==========================================
- Hits 24177 24174 -3
- Misses 9549 9557 +8
+ Partials 1402 1397 -5 Continue to review full report in Codecov by Sentry.
|
|
/test ci-etcd-robustness-amd64 |
|
@serathius: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -106,8 +106,17 @@ func exploratoryScenarios(_ *testing.T) []testScenario { | |||
| clusterOfSize1Options = append(clusterOfSize1Options, e2e.WithClusterSize(1)) | |||
| // Add LazyFS only for traffic with lower QPS as it uses a lot of CPU lowering minimal QPS. | |||
| if enableLazyFS && tp.Profile.MinimalQPS <= 100 { | |||
| clusterOfSize1Options = append(clusterOfSize1Options, e2e.WithLazyFSEnabled(true)) | |||
| name = filepath.Join(name, "LazyFS") | |||
| // Set CompactionBatchLimit to default when LazyFS is enabled, because frequent compaction uses a lot of CPU too. | |||
There was a problem hiding this comment.
I didn't meant WithCompactionBatchLimit, but executing compaction in traffic. Still let's see if this is enough.
There was a problem hiding this comment.
I was thinking of something more like #18181
#18144
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.