Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $(MAKE) instead of make #18204

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Jun 18, 2024

Recursive make commands should always use the variable MAKE, as the value of this variable is the file name with which make was invoked

References:

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Recursive make commands should always use the variable MAKE, as
the value of this variable is the file name with which make was invoked

Reference:
- https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @henrybear327.

/cc @serathius
/retest

@serathius serathius merged commit 97a4068 into etcd-io:main Jun 19, 2024
48 checks passed
@henrybear327 henrybear327 deleted the make/robustness branch June 20, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants