[3.5] Fix dependency inconsistency detection and add make verify-dep #18207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ivanvc |
Makefile's target `verify-dep` current behavior is to use `go list` to check consistent dependency versions from direct dependencies. Ignoring indirect dependencies in a multi-module project could lead to version mismatches. If module A imports module B, module B's dependency will be an indirect dependency in module A. Which can potentially have a version mismatch. Therefore, use `go mod edit` with indirect dependencies, too. So it can work with all dependencies defined in go.mod. Fix displaying dependencies with mismatches, as the old code was searching with grep just for the prefix, which would show other dependencies that shared the same prefix. Reference: - etcd-io#18205 Signed-off-by: Ivan Valdes <ivan@vald.es> Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327
force-pushed
the
ci/fix_dep_inconsistency
branch
from
00413f7
to
fb3fe32
Compare
|
Discovered several inconsistencies Update: fixed with subsequent commits |
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
…on v0.0.0-20180306012644-bacd9c7ef1dd Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
|
LGTM. Thanks, @henrybear327 |
ahrtr
changed the title
ahrtr
approved these changes
Jun 20, 2024
|
Link to #18180 |
aneesh1
pushed a commit
to DataDog/etcd
that referenced
this pull request
Sep 24, 2024
…stency [3.5] Fix dependency inconsistency detection and add make verify-dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile's target
verify-depcurrent behavior is to usego listto check consistent dependency versions from direct dependencies. Ignoring indirect dependencies in a multi-module project could lead to version mismatches. If module A imports module B, module B's dependency will be an indirect dependency in module A. Which can potentially have a version mismatch. Therefore, usego mod editwith indirect dependencies, too. So it can work with all dependencies defined in go.mod.Fix displaying dependencies with mismatches, as the old code was searching with grep just for the prefix, which would show other dependencies that shared the same prefix.
Reference:
verify-deptarget #18205Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.