Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in mvcc: store.go #18209

Closed
wants to merge 0 commits into from
Closed

fix typo in mvcc: store.go #18209

wants to merge 0 commits into from

Conversation

Willhow-Gao
Copy link
Contributor

fix typo in mvcc module,store.go

@k8s-ci-robot
Copy link

Hi @Willhow-Gao. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@henrybear327
Copy link
Contributor

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an even better fix, would be to remove the named return values, as they're not used in the implementation.

@Willhow-Gao
Copy link
Contributor Author

I think an even better fix, would be to remove the named return values, as they're not used in the implementation.

thx for your advice,already removed

@ivanvc
Copy link
Member

ivanvc commented Jun 21, 2024

@Willhow-Gao, can you squash your commits into a single one, and sign your commits so the developer certificate of origin (DCO) check passes?

You can squash your three commits and sign off by running:

git reset --soft HEAD~3
git commit --signoff -m <commit message>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants