etcdctl: add support for filtering by {min,max} x {create,mod} x {revision}

[jcferretti]

etcdctl is missing options to modify get opts for WithMinCreateRev, WithMaxCreateRev, WithMinModRev, WithMaxModRev.

[k8s-ci-robot]

Hi @jcferretti. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[henrybear327]

/ok-to-test

@jcferretti please remember to sign-off your commits! Thanks!

[jcferretti]

/retest

[jmhbnz]

LGTM - Thanks @jcferretti

Once merged please raise an update to changelog for 3.6.

[ahrtr]

It looks much better now. Please squash the commits.

[jcferretti]

It looks much better now. Please squash the commits.

I will do this, but I want to point out that this is strange. Github should squash on merge, so for the final result it shouldn't matter, and on the other hand review history and history of changes of the PR itself is lost.

So I don't understand why this would be (a) necessary (b) desirable.

[jcferretti]

/retest

[ahrtr]

I will do this, but I want to point out that this is strange.

• Nobody cares about your intermediate commits for such a simple PR.
• Don't pollute the commit history.

[ahrtr]

LGTM

[jcferretti]

• Don't pollute the commit history.

How is the commit history going to be polluted if github squashes on merge?

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests