-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Remove gsutil acl command for bucket permissions from release.sh #18286
[3.5] Remove gsutil acl command for bucket permissions from release.sh #18286
Conversation
The bucket is already fully public so new releases don't need to run this command. This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket. Signed-off-by: James Blair <mail@jamesblair.net>
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
/ok-to-test
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green.
@jmhbnz, there's no OWNERS in the release-3.5 branch. Should we open an issue? Or should we just copy whatever is on main?
Hmm yeah we should probably backport the migration to |
Works for me. Thanks |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ry-pick-18250-to-release-3.5 [release-3.5] Remove gsutil acl command for bucket permissions from release.sh
This is an automated cherry-pick of #18250
/assign jmhbnz