Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep release process documentation up to date #18399

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Aug 3, 2024

This pull request updates our release process to reflect tweaking branch protection settings before and after performing a release.

I also fixed some markdownlint errors and tidied a few other areas in the doc.

Signed-off-by: James Blair <mail@jamesblair.net>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented Aug 4, 2024

I also fixed some markdownlint errors and tidied a few other areas in the doc.

This is somewhat related to #18059. Marker is limited to checking for broken links but doesn't do any listing at the level where markdownlint does. I'm not sure if we should consider using NodeJS' markdownlint, as it would need us to write an independent prow job that has the NodeJS environment.

@wenjiaswe
Copy link
Contributor

/lgtm
Thanks!

@ahrtr
Copy link
Member

ahrtr commented Aug 7, 2024

/retest

@jmhbnz jmhbnz merged commit ad942b7 into etcd-io:main Aug 11, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants