Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add animated quick demo #5279

Merged
merged 1 commit into from
May 19, 2016
Merged

Documentation: add animated quick demo #5279

merged 1 commit into from
May 19, 2016

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 5, 2016

As discussed before, I would like to add quick demo documentation.

@gyuho
Copy link
Contributor Author

gyuho commented May 5, 2016

/cc @heyitsanthony @xiang90

Thanks.

@@ -0,0 +1,231 @@
### Demo

#### set up cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set up the cluster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just addressed all. PTAL. Thanks.

@@ -10,6 +10,7 @@ New etcd users and developers should get started by [downloading and building][d

The easiest way to get started using etcd as a distributed key-value store for your applications is to [set up a local cluster][local_cluster].

- [Quick demo][demo]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to getting started section? Add a sentence to say here is a quick demo?

@xiang90
Copy link
Contributor

xiang90 commented May 7, 2016

/cc @joshix Please take a look of this doc. Thanks!

@gyuho
Copy link
Contributor Author

gyuho commented May 7, 2016

Just used all with machine (re-recorded gifs with machine). Will fix more based on Josh's feedback.

Thanks!

@gyuho gyuho changed the title Proposal: add demo/tutorial doc for quick demo Documentation: add animated quick demo May 7, 2016
@gyuho gyuho force-pushed the demo branch 3 times, most recently from fa55b37 to 3b09a5e Compare May 7, 2016 03:55
@joshix
Copy link
Contributor

joshix commented May 8, 2016

I'll look at this asap after Fest monday and tuesday, folks

@gyuho
Copy link
Contributor Author

gyuho commented May 10, 2016

Just re-recorded some commands with correct write-out flag. And added snapshot demo.

@joshix Thanks! This is not urgent btw.

@@ -0,0 +1,286 @@
### Demo

Below is an example work flow of using etcd in production.
Copy link
Contributor

@joshix joshix May 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This series of examples shows the basic procedures for working with an etcd cluster."

@joshix
Copy link
Contributor

joshix commented May 18, 2016

@gyuho Shouldn't there be image files in this changeset?

@gyuho
Copy link
Contributor Author

gyuho commented May 18, 2016

@joshix I think it's better to serve image files in a separate storage? You can see the working example here https://github.com/gyuho/etcd/blob/c835cf9fffc6b70c639e864b56003b9dd4390ef4/Documentation/demo.md.

Will fix based on your comments now. Thanks!

@gyuho
Copy link
Contributor Author

gyuho commented May 18, 2016

@joshix All addressed. PTAL.

Thanks a lot!

@gyuho
Copy link
Contributor Author

gyuho commented May 19, 2016

@joshix Ping? Thanks!

@gyuho gyuho mentioned this pull request May 19, 2016
@joshix
Copy link
Contributor

joshix commented May 19, 2016

LGTM

@gyuho
Copy link
Contributor Author

gyuho commented May 19, 2016

Thanks!

@gyuho gyuho merged commit be4fb63 into etcd-io:master May 19, 2016
@gyuho gyuho deleted the demo branch May 19, 2016 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants