-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: add animated quick demo #5279
Conversation
Thanks. |
@@ -0,0 +1,231 @@ | |||
### Demo | |||
|
|||
#### set up cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set up the cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just addressed all. PTAL. Thanks.
@@ -10,6 +10,7 @@ New etcd users and developers should get started by [downloading and building][d | |||
|
|||
The easiest way to get started using etcd as a distributed key-value store for your applications is to [set up a local cluster][local_cluster]. | |||
|
|||
- [Quick demo][demo] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to getting started section? Add a sentence to say here is a quick demo?
/cc @joshix Please take a look of this doc. Thanks! |
Just used all with Thanks! |
fa55b37
to
3b09a5e
Compare
I'll look at this asap after Fest monday and tuesday, folks |
Just re-recorded some commands with correct @joshix Thanks! This is not urgent btw. |
@@ -0,0 +1,286 @@ | |||
### Demo | |||
|
|||
Below is an example work flow of using etcd in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This series of examples shows the basic procedures for working with an etcd cluster."
@gyuho Shouldn't there be image files in this changeset? |
@joshix I think it's better to serve image files in a separate storage? You can see the working example here https://github.com/gyuho/etcd/blob/c835cf9fffc6b70c639e864b56003b9dd4390ef4/Documentation/demo.md. Will fix based on your comments now. Thanks! |
@joshix All addressed. PTAL. Thanks a lot! |
@joshix Ping? Thanks! |
LGTM |
Thanks! |
As discussed before, I would like to add quick demo documentation.