fix(mod/lock): correct watch index to remove cpu load #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,16 +42,16 @@ func (s lockNodes) FindByValue(value string) (*etcd.Node, int) { | |||
| } | |||
|
|
|||
| // Retrieves the index that occurs before a given index. | |||
There was a problem hiding this comment.
@benbjohnson I think we need to add some comments to make this function more easy to understand.
Find the node with the largest index in the lockNodes that is smaller than the given index. Also return the lastModified index of that node.
There was a problem hiding this comment.
@xiangli-cmu I expanded on the function comment and a comment within the function itself.
The waitIndex was being pulled from the wrong node in the lock parent which caused the watch to be returned immediately. This caused a continuous set of calls while a client was waiting for a lock.
|
lgtm |
benbjohnson
added a commit
that referenced
this pull request
Feb 27, 2014
fix(mod/lock): correct watch index to remove cpu load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waitIndex was being pulled from the wrong node in the lock parent which caused the watch to be returned immediately. This caused a continuous stream of get/watch calls while a client was waiting for a lock.
Confirmed with @oleksiyk that this change fixes #575.
/cc @philips @xiangli-cmu