fix small bugs that are found in issue #579 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #579 |
| // and would be available in Go1.3 | ||
| // More: https://codereview.appspot.com/69280043/ | ||
| ConnectTimeout: dialTimeout, | ||
| ReadWriteTimeout: responseHeaderTimeout, |
There was a problem hiding this comment.
I still suggest explicitly setting RequestTimeout, for clarity (rather than relying on default)
There was a problem hiding this comment.
@mreiferson That makes sense.
…cked Currently this is a workaround. And it should be fixed in Go1.3.
Setting request timeout is covered by go-httpclient now.
|
@xiangli-cmu |
|
lgtm |
yichengq
added a commit
that referenced
this pull request
Mar 1, 2014
fix bugs that are found in issue #579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #579