fix(server/transporter.go) fix the short timeout problem of sending snapshot #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshot Snapshot can be tens of MB. We need to have a minute level timeout for sending snapshot. We add a separate snapshot http client for snapshot request, which has 120s timeout.
|
@philips Shall we also add test in this pull request? But we will be testing the httpclient package from https://github.com/mreiferson/go-httpclient. |
|
/cc @unihorn |
| @@ -58,6 +78,9 @@ func NewTransporter(followersStats *raftFollowersStats, serverStats *raftServerS | |||
| func (t *transporter) SetTLSConfig(tlsConf tls.Config) { | |||
| t.transport.TLSClientConfig = &tlsConf | |||
| t.transport.DisableCompression = true | |||
|
|
|||
| t.snapshotTransport.TLSClientConfig = &tlsConf | |||
| t.snapshotTransport.DisableCompression = true | |||
There was a problem hiding this comment.
Does it make sense to disable compression on large things like the snapshot?
There was a problem hiding this comment.
@philips I just copied the previous setting. I do not think we are using gzip on the server side for now. So disabling or not makes no difference.
|
lgtm |
|
@xiangli-cmu Does this fix #591 or do we need to make snapshotting itself more efficient too? |
|
@xiangli-cmu Do you want to merge this one? |
xiang90
added a commit
that referenced
this pull request
Mar 12, 2014
fix(server/transporter.go) fix the short timeout problem of sending snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot can be tens of MB. We need to have a minute level timeout for sending snapshot.
We add a separate snapshot http client for snapshot request, which has 120s timeout.
fix #591
There is issue in raft too. I have fixed that in a coming pull request for raft.