etcdserver, backend: configure mmap size based on quota #7525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
approved these changes
Mar 17, 2017
heyitsanthony
force-pushed
the
big-backend
branch
2 times, most recently
from
ee92272
to
7468669
Compare
heyitsanthony
force-pushed
the
big-backend
branch
from
7468669
to
8a3fee1
Compare
Codecov Report
@@ Coverage Diff @@
## master #7525 +/- ##
==========================================
+ Coverage 70.23% 70.23% +<.01%
==========================================
Files 320 320
Lines 26205 26223 +18
==========================================
+ Hits 18405 18419 +14
- Misses 6343 6352 +9
+ Partials 1457 1452 -5
Continue to review full report at Codecov.
|
xiang90
reviewed
Mar 22, 2017
| plog.Warningf("backend quota %v exceeds maximum quota %v; using maximum", s.Cfg.QuotaBackendBytes, backend.MaxQuotaBytes) | ||
| return &backendQuota{s, backend.MaxQuotaBytes} | ||
| if s.Cfg.QuotaBackendBytes > MaxQuotaBytes { | ||
| plog.Warningf("backend quota %v exceeds maximum recommended quota %v", s.Cfg.QuotaBackendBytes, MaxQuotaBytes) |
There was a problem hiding this comment.
so we change the behavior here to allow user to use more than 8gb?
|
LGTM |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanism for permitting mmaps > 10GB.