Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add experimental serializable ordering feature to grpcproxy #8315

Merged
merged 3 commits into from
Jul 28, 2017
Merged

add experimental serializable ordering feature to grpcproxy #8315

merged 3 commits into from
Jul 28, 2017

Conversation

heyitsanthony
Copy link
Contributor

Anthony Romano added 2 commits July 26, 2017 20:58
gyuho
gyuho reviewed Jul 27, 2017
View reviewed changes
etcdmain/grpc_proxy.go Outdated
if err == nil {
break
}
plog.Warningf("ordering recocery failed, retrying in 1s (%v)", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recovery?

etcdmain: add --experimental-serializable-ordering to grpc proxy
f6acd03 
Connect to another endpoint on stale reads.
gyuho
gyuho approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@heyitsanthony heyitsanthony merged commit 2951faf into etcd-io:master Jul 28, 2017
@heyitsanthony heyitsanthony deleted the experimental-ordering branch July 28, 2017 21:49
@gyuho gyuho mentioned this pull request Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyitsanthony @gyuho