corruption alarm #8420
Merged
corruption alarm #8420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
force-pushed
the
corrupt-alarm
branch
from
0ca2287
to
14f0c2f
Compare
|
Would this cover #8313 as well? |
heyitsanthony
force-pushed
the
corrupt-alarm
branch
from
14f0c2f
to
8e1b0ca
Compare
|
@heyitsanthony We probably should put this under an alpha feature flag initially? |
gyuho
reviewed
Aug 18, 2017
etcdserver/apply.go
Outdated
| @@ -577,9 +577,11 @@ func (a *applierV3backend) Alarm(ar *pb.AlarmRequest) (*pb.AlarmResponse, error) | |||
| break | |||
| } | |||
|
|
|||
| plog.Warningf("alarm %v raised by peer %+v", m.Alarm, types.ID(m.MemberID)) | |||
There was a problem hiding this comment.
Should just be %s? Becaue types.ID implements String method?
gyuho
reviewed
Aug 18, 2017
etcdserver/corrupt.go
Outdated
| for _, c := range cli.Endpoints() { | ||
| ctx, cancel := context.WithTimeout(context.Background(), s.Cfg.ReqTimeout()) | ||
| resp, herr := cli.HashKV(ctx, c, rev) | ||
| fmt.Printf("got %+v %v\n", resp, err) |
There was a problem hiding this comment.
Log instead of print? Or just delete?
heyitsanthony
force-pushed
the
corrupt-alarm
branch
11 times, most recently
from
13588d7
to
b0dfe76
Compare
|
Modest thrashing on this one. Putting cmux on the peer port on the integration package caused trouble due to connections hanging in the matcher phase on shutdown. I vendored the mainline cmux since it has a read timeout which eventually cancels the read. |
gyuho
reviewed
Aug 21, 2017
| @@ -216,6 +216,9 @@ func newConfig() *config { | |||
| // auth | |||
| fs.StringVar(&cfg.AuthToken, "auth-token", cfg.AuthToken, "Specify auth token specific options.") | |||
|
|
|||
| // experimental | |||
| fs.DurationVar(&cfg.ExperimentalCorruptCheckTime, "experimental-corrupt-check-time", cfg.ExperimentalCorruptCheckTime, "Duration of time between cluster corruption check passes.") | |||
There was a problem hiding this comment.
Also add this to https://github.com/coreos/etcd/blob/master/etcdmain/help.go?
heyitsanthony
force-pushed
the
corrupt-alarm
branch
from
b0dfe76
to
603f84b
Compare
added 7 commits
August 22, 2017 09:59
added 4 commits
August 22, 2017 09:59
Has fixes not in fork. Includes SetReadTimeout.
Official release is ahead of the fork.
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds grpc to peers to get the hashkv rpc.
Fixes #7125