grpcproxy: respect KeysOnly flag #8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2017 09:50
Test was checking key name is returned, but was not correctly checking no value is returned.
Codecov Report
@@ Coverage Diff @@
## master #8552 +/- ##
=========================================
Coverage ? 65.96%
=========================================
Files ? 360
Lines ? 29568
Branches ? 0
=========================================
Hits ? 19505
Misses ? 8402
Partials ? 1661
Continue to review full report at Codecov.
|
xiang90
reviewed
Sep 13, 2017
| cx.t.Fatal(err) | ||
| } | ||
| if err := spawnWithExpects(cmdArgs, "val"); err == nil { | ||
| cx.t.Fatalf("got value but passed --keys-only") |
There was a problem hiding this comment.
nit: t.Errorf is better here.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8478