Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compactor: adjust interval for period <1-hour #9482

Closed
wants to merge 1 commit into from
Closed

compactor: adjust interval for period <1-hour #9482

wants to merge 1 commit into from

Conversation

yudai
Copy link
Contributor

@yudai yudai commented Mar 23, 2018 •
edited
Loading

gyuho
gyuho reviewed Mar 23, 2018
View reviewed changes
compactor/periodic.go
if itv < (6 * time.Minute) { // t.period is less than hour
// if t.period is less than 6-minute,
// retry interval is t.period.
// if we divide byretryDivisor, it's too aggressive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/byretryDivisor/by retryDivisor/?

@gyuho
Copy link
Contributor

gyuho commented Mar 23, 2018 •
edited
Loading

@yudai Me and @fanminshi have an alternative solution that might be simpler than this.
Will send another PR for your review.
Thanks!

@yudai
Copy link
Contributor Author

yudai commented Mar 23, 2018

@gyuho @fanminshi, sure thing! I'm totally fine with that. Let's choose the simpler way!

@gyuho gyuho mentioned this pull request Mar 23, 2018
Merged
@yudai
Copy link
Contributor Author

yudai commented Mar 23, 2018

Moving to #9485.

@yudai yudai closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho left review comments

Assignees
No one assigned
Labels
backport/v3.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yudai @gyuho