-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: more metrics for bboltdb transaction #9834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a question in the last etcd community meeting of if we should keep the "etcd_debugging" but since we don't have a final decision on that, I think it makes sense to continue to use it.
The histograms look good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks @xiang90 !
Added change log and missing prometheus register calls. Merging in greens. |
Also replaced metrics naming to
|
@gyuho Thank you! |
cc @wenjiaswe |
@gyuho @jpbetz
We observed high latency in the commit call. Adding more metrics can help to understand which part of bbolt commit is the root cause.