Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: support rewriting labels #13

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

heyitsanthony
Copy link
Contributor

Lets a failpoint to jump to a label only used by failpoints.

/cc @gyuho

Lets a failpoint to jump to a label only used by failpoints.
@gyuho
Copy link
Contributor

gyuho commented Apr 24, 2018

@heyitsanthony

Is there any way that we can release the lock (from defer Acquire) on continue? Otherwise, for {} will keep running continue without release, so cannot run DELETE request. My attempt was add https://github.com/coreos/gofail/pull/12/files#diff-81f179a840cfbb903d2dbc4d8c2152a5R66.

Thanks!

@heyitsanthony
Copy link
Contributor Author

@gyuho OK, defer is broken in general. e.g., this will starve the delete too:

for ctx.Err() == nil {
  // gofail: var abc struct{}
  // fmt.Println("abc")
  whatever()
}

@gyuho
Copy link
Contributor

gyuho commented Apr 24, 2018

@heyitsanthony You are right. defer seems broken then. I will create a separate issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants