Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix golangci-lint errors #25

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix golangci-lint errors #25

merged 1 commit into from
Aug 26, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Aug 26, 2022 •
edited
Loading

Fix golangci-lint errors below,

  Running [/home/runner/golangci-lint-1.29.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: ineffectual assignment to `fps` (ineffassign)
  Error: ineffectual assignment to `err` (ineffassign)
  Error: ST1003: should not use underscores in Go names; var fp_term should be fpTerm (stylecheck)
  
  Error: issues found
  Ran golangci-lint in 805ms

Refer to https://github.com/etcd-io/gofail/runs/8025843669?check_suite_focus=true

Signed-off-by: Benjamin Wang wachao@vmware.com

@ahrtr
fix golangci-lint errors
cb00255 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr
Copy link
Member Author

ahrtr commented Aug 26, 2022

cc @spzala @serathius @ptabor

spzala
spzala approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks @ahrtr

@spzala spzala merged commit d0d2a96 into etcd-io:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spzala spzala spzala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrtr @spzala