gofail --version should exit with 0
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it exits with code 1, and when executing `make`, it always display an error like below, $ make GO_BUILD_FLAGS="-v" ./build.sh go.etcd.io/gofail/code go.etcd.io/gofail ./gofail --version Git SHA: dc004b5 Go Version: go1.19.2 gofail Version: 0.1.0 Go OS/Arch: linux/amd64 make: *** [gofail] Error 1 Signed-off-by: Benjamin Wang <wachao@vmware.com>
spzala
approved these changes
Nov 20, 2022
|
Thanks @spzala for the quick review |
|
Yrw @ahrtr Thank you for continued improvements in the gofail. |
|
Thank you for fixing @ahrtr |
ramil600
pushed a commit
to ramil600/gofail
that referenced
this pull request
Nov 22, 2022
`gofail --version` should exit with 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was introduced in #35. The command
gofail --versionexits with code 1. It isn't correct. Instead, it should exit with 0.When executing
make, it always display an error like below,$ make
GO_BUILD_FLAGS="-v" ./build.sh
go.etcd.io/gofail/code
go.etcd.io/gofail
./gofail --version
Git SHA: dc004b5
Go Version: go1.19.2
gofail Version: 0.1.0
Go OS/Arch: linux/amd64
make: *** [gofail] Error 1
Signed-off-by: Benjamin Wang wachao@vmware.com
cc @spzala @ramil600