Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: execute next term in the chain #6

Closed
wants to merge 1 commit into from
Closed

runtime: execute next term in the chain #6

wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 17, 2017

Reproduce

FAILPOINTS=1 ./build
GOFAIL_HTTP=:2381 ./bin/etcd

curl http://localhost:2381/github.com/coreos/etcd/etcdserver/raftBeforeSave -XPUT -d'sleep(1000)->panic("etcd-tester")'
ETCDCTL_API=3 ./bin/etcdctl get foo

Current code does not execute panic("etcd-tester").

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@heyitsanthony
Copy link
Contributor

Already covered by https://github.com/coreos/gofail/blob/master/runtime/terms_test.go#L32?

The failpoint won't execute all the terms in the cascade. See the examples in the failpoint manpage (e.g., "5*return(5)->0.1%return(22)")

sleep(1000)->panic("etcd-tester") should probably be 1*sleep(1000)->panic("etcd-tester")

@gyuho
Copy link
Contributor Author

gyuho commented May 17, 2017

Yeah 1*sleep(1000)->panic("etcd-tester") works. Thanks!

@gyuho gyuho closed this May 17, 2017
@gyuho gyuho deleted the chain branch May 17, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants