Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofail.go: remove tmp file if os.Rename fails #8

Merged
merged 1 commit into from
Nov 9, 2017
Merged

gofail.go: remove tmp file if os.Rename fails #8

merged 1 commit into from
Nov 9, 2017

Conversation

lorneli
Copy link
Contributor

@lorneli lorneli commented Oct 30, 2017

No description provided.

@lorneli
Copy link
Contributor Author

lorneli commented Nov 8, 2017

I ran gofail on vmhgfs previously. It's a vmware file system, which supports shared folder between host and guest os but doesn't support rename operation. So renaming tmp file failed and I found the tmp file still stayed in that directory.

@xiang90
Copy link
Contributor

xiang90 commented Nov 9, 2017

lgtm

@xiang90 xiang90 merged commit 38defe9 into etcd-io:master Nov 9, 2017
@lorneli lorneli deleted the rename_fail branch November 11, 2017 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorneli @xiang90