Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: golang ci lint check failure #3

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix: golang ci lint check failure #3

merged 1 commit into from
Nov 28, 2022

Conversation

nic-chen
Copy link
Contributor

@nic-chen
fix: golang ci lint check failure
6bf4f7f 
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
@nic-chen
Copy link
Contributor Author

cc @ahrtr have a review, thanks.

@ahrtr
Copy link
Member

ahrtr commented Nov 28, 2022

Thanks @nic-chen for fixing this.

But I am curious why previous we do not see such failure in etcd repo on raft? @cenkalti @chavacava @vivekpatani @ldez

ahrtr
ahrtr approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @nic-chen

@ahrtr ahrtr merged commit f863b3b into etcd-io:main Nov 28, 2022
@nic-chen nic-chen deleted the fix/lint branch November 28, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nic-chen @ahrtr