Use legacy configs #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshTheWanderer
force-pushed
the
fix/legacy-config
branch
from
83d4911
to
923fe80
Compare
JoshTheWanderer
force-pushed
the
fix/legacy-config
branch
from
923fe80
to
34fde89
Compare
|
gavmck
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-config-next,eslint-plugin-importandeslint-plugin-jsx-a11ydonot support the new flat file config and/or eslint v9.
Because of the above, we have to stay on v8 with the non-flat-file config.
Newer versions of
eslint-plugin-securityandeslint-plugin-jsonsupport thenew flat file config by default, which broke our config.
This PR switches to using the legacy configs for the above two packages, updates
the supported node versions in anticipation of eslint v9, and adds a basic CI
workflow to catch any broken configs.
Closes ETCH-621.