Adding (partial) support for differential.querydiffs, and a timeout client option #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
cc: @Pawka
Thank you for maintaining that library (and @jpoehls for the original implementation), I found it very useful while implementing a project at my company!
I had to make those two changes though:
differential.querydiffs
, note that the structure is missing a couple fields that are very tricky to un-marshal, hope that's fine for now.In the area of 1., another option I expect a need for is the ability to pass custom HTTP headers. I think it's reasonable at this time to add a new
Header
field (of typenet.http.Header
), but I'm wondering how well that approach of passing HTTP options viaClientOptions
is going to scale, so I'm wondering if other people have an opinion here.Let me know, if you have any question.
Best