Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding (partial) support for differential.querydiffs, and a timeout client option #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lopter
Copy link
Collaborator

@lopter lopter commented Feb 10, 2018

Hello,

cc: @Pawka

Thank you for maintaining that library (and @jpoehls for the original implementation), I found it very useful while implementing a project at my company!

I had to make those two changes though:

  1. Add a timeout option so that you can fail fast on the conduit calls;
  2. Add request/response structs for differential.querydiffs, note that the structure is missing a couple fields that are very tricky to un-marshal, hope that's fine for now.

In the area of 1., another option I expect a need for is the ability to pass custom HTTP headers. I think it's reasonable at this time to add a new Header field (of type net.http.Header), but I'm wondering how well that approach of passing HTTP options via ClientOptions is going to scale, so I'm wondering if other people have an opinion here.

Let me know, if you have any question.

Best

This endpoint returns a complex response where a couple fields are not
parsed into the response object.
This allows code to fail fast which is really useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant