core/vm,params/vars: "correctly" implement EIP2200 SLOAD gas cost change #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://eips.ethereum.org/EIPS/eip-2200 - https://eips.ethereum.org/EIPS/eip-1884 EIP2200 is implemented simultaneously with 1884 on the ETH nets, rendering this somewhat redundant. But other networks may care, and this changeset should be handled carefully, since either or both 2200 1884 may be live with or without the other. Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
added
F2-bug 🐞
M2-config 📂
M4-core ⛓
P2-asap 🌊
Y2-pendingupstream 📂
meowsbits
changed the title
meowsbits
changed the title
soc1c
approved these changes
Feb 13, 2020
|
restarted travis |
|
Releasing this merged version to the testnets, some of which have already "begun" running EIP2200, posing a consistency problem. It could break the testnets, or? |
|
Testnets are already broken and need to be rolled back. All we need is releases for Multi Geth and Parity. |
This was referenced Feb 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP2200 is implemented simultaneously with 1884
on the ETH nets, rendering this somewhat redundant.
But other networks may care, and this changeset
should be handled carefully, since either or both
2200 1884 may be live with or without the other.
Signed-off-by: meows b5c6@protonmail.com