Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm,params/vars: "correctly" implement EIP2200 SLOAD gas cost change #144

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

meowsbits
Copy link
Member

EIP2200 is implemented simultaneously with 1884
on the ETH nets, rendering this somewhat redundant.
But other networks may care, and this changeset
should be handled carefully, since either or both
2200 1884 may be live with or without the other.

Signed-off-by: meows b5c6@protonmail.com


- https://eips.ethereum.org/EIPS/eip-2200
- https://eips.ethereum.org/EIPS/eip-1884

EIP2200 is implemented simultaneously with 1884
on the ETH nets, rendering this somewhat redundant.
But other networks may care, and this changeset
should be handled carefully, since either or both
2200 1884 may be live with or without the other.

Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits changed the title core/vm,params/vars: implement missing SLOAD gas cost change core/vm,params/vars: "correctly" implement SLOAD gas cost change Feb 11, 2020
@meowsbits meowsbits changed the title core/vm,params/vars: "correctly" implement SLOAD gas cost change core/vm,params/vars: "correctly" implement EIP2200 SLOAD gas cost change Feb 11, 2020
Copy link

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soc1c soc1c closed this Feb 13, 2020
@soc1c soc1c reopened this Feb 13, 2020
@soc1c
Copy link

soc1c commented Feb 13, 2020

restarted travis

@soc1c soc1c merged commit 0cd6b91 into master Feb 13, 2020
@soc1c soc1c deleted the fix/eip-2200-sload-gas branch February 13, 2020 09:48
@meowsbits
Copy link
Member Author

meowsbits commented Feb 13, 2020

Releasing this merged version to the testnets, some of which have already "begun" running EIP2200, posing a consistency problem.

It could break the testnets, or?

@soc1c
Copy link

soc1c commented Feb 14, 2020

Testnets are already broken and need to be rolled back. All we need is releases for Multi Geth and Parity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants