When to use CatalystWrapper vs CatalystWrapper&

[adamv]

EditorCtrls get passed a CatalystWrapper& reference, which they store in a reference member variable.

RevTooltip gets passed a CatalystWrapper (not a reference), which is stored in a non-reference member variable.

Is there a checklist for when to use what?

On first look it seems that changing RevTooltip to also use references wouldn't be a bad thing, but I wonder if they are using non-references due to a big fix.

[astigsen]

Non-reference CatalystWrappers should only be used when you are not sure that the parent will stay around. So the one in RevTooltip should be safe to change to a reference.

[adamv]

Thanks.