Build warnings in eApp.cpp (Windows build)

[adamv]

There are some build warnings:
eApp.cpp
- c:\Projects\e\external\libtomcrypt\src\headers\tomcrypt_cfg.h(11) : warning C4565: ‘malloc’ : redefinition; the symbol was previously declared with __declspec(restrict)
- c:\Projects\e\external\libtomcrypt\src\headers\tomcrypt_cfg.h(12) : warning C4565: ‘realloc’ : redefinition; the symbol was previously declared with __declspec(restrict)
- c:\Projects\e\external\libtomcrypt\src\headers\tomcrypt_cfg.h(13) : warning C4565: ‘calloc’ : redefinition; the symbol was previously declared with __declspec(restrict)
- c:\Projects\e\external\libtomcrypt\src\headers\tomcrypt_cfg.h(14) : warning C4565: ‘free’ : redefinition; the symbol was previously declared with __declspec(noalias)
- c:\Projects\e\external\wxwidgets\include\wx/datetime.h(1108) : warning C4996: ‘localtime’: This function or variable may be unsafe. Consider using localtime_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
- C:\Program Files\Microsoft Visual Studio 9.0\VC\include\time.inl(114) : see declaration of ‘localtime’

(Duplicates removed.)

e.exe still builds and runs, seemingly OK, but it would be nice to have the build be as warning-free as possible.

(Note, I’m bad at Markdown formatting.)

[astigsen]

Yes, there are quite a few warnings from the external libraries. The best would be if we could fix them, and then have the fixes included upstream. But as a last resort we can just patch them.

[adamv]

These warnings have since been removed in this commit: http://github.com/etexteditor/e/commit/6f0e1a1dfd042c5a07c07a66ac32dff4de501e5d

[adamv]

Closing.